npmignore cleanup; adding some types to Client #1049
Merged
+14
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples - I personally find example code to be helpful in terms of getting up and running with a new library. I also think it gives the library developer an opportunity to define best practices since it will be copy/pasted by everyone.
Added
/docs
to.npmignore
- I think ultimately the project should use an npm white list.It looks like the
last*
properties ofClient
should be public so I changed that.